Repository navigation
fix(pi): release settled turns before notifying observers - #617
Open
stamp-build[bot] wants to merge 1 commit into
Open
stamp-build[bot] wants to merge 1 commit into
stamp-build[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a host submits its next prompt synchronously from Pi's
turn_endedobserver, status already says idle but SDK/RPC still reserve the previous run and reject the prompt as busy. Release that run before publishing the terminal frame, then drain held inputs. An observer's new prompt or compaction cannot overtake held inputs, and an observer's queue call joins the tail. RPC replies are scoped to their original launch so a late handled/refused response cannot clear the next run.Pi Durable uses a separate native submission queue and record fold. Its existing path passes the same native observer control; its product code is unchanged. Document Pi SDK/RPC alongside the existing held-queue exception: while OAR holds input, status can briefly show idle even though prompt is busy. Recording that queue's ownership is separate work.
Validation:
Task #162. This is a separate follow-up to #614; merge after the 0.87.0 release hold lifts and this head passes review and CI.