Open
Conversation
a minimum number of idle connections and a maximum number of open connections.
|
good, good, very good! |
Collaborator
|
I like the look of this PR (lots of tests relative to the rest of the change!). As discussed in a bunch of issues though, we're likely to get pipelining working which solves the majority of this; you'll only need 1 or 2 conns per server instead of infinity. Might be worth looking through this change in case we want idletimeout at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close connections based on an idle timeout with an option to maintain a minimum number of idle connections and a maximum number of open connections per address.