This repository was archived by the owner on Jan 5, 2024. It is now read-only.
TemporalModelCommitments #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
please merge upstream again, travis/awscli were giving us a hard time |
mschrimpf
suggested changes
Apr 1, 2019
Member
mschrimpf
left a comment
mschrimpf
left a comment
There was a problem hiding this comment.
Looks good overall, I left a few comments in the code.
Please also remove tests/__pycache__
| temporal_maps[region] = time_bin_regressor | ||
| return temporal_maps | ||
|
|
||
| def _set_region_coords(self, activations, layer_regions): |
Member
There was a problem hiding this comment.
I'll work on a fix for this soon, so that you hopefully won't need this here anymore (brain-score/brainio_base#1)
mschrimpf
reviewed
Apr 2, 2019
mschrimpf
reviewed
Apr 4, 2019
| if type(variation) is not list: | ||
| variation = [variation] | ||
| assembly_dir = path.join(path.dirname(__file__), 'test_temporal_assemblies') | ||
| test_assembly_filename = 'temporal_test_{}_var{}.pkl'.format(region, ''.join(str(v) for v in variation)) |
Member
There was a problem hiding this comment.
you can also do f'temporal_test_{region}_var{"".join(str(v) for v in variation)}.pkl'
mschrimpf
reviewed
Apr 4, 2019
| expected_region_count = len(expected_region) | ||
| expected_time_bin_count = len(training_assembly.time_bin.values) | ||
|
|
||
| extractor = pytorch_custom() |
mschrimpf
reviewed
Apr 4, 2019
| temporal_model = TemporalModelCommitment('', extractor, layers) | ||
| # commit region: | ||
| temporal_model.commit_region(region, commit_assembly) | ||
| temporal_model.do_commit_region(region) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.