This repository was archived by the owner on Jan 5, 2024. It is now read-only.
fix slow concat #71
Open
fix slow concat #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschrimpf
approved these changes
Aug 10, 2023
Member
mschrimpf
left a comment
mschrimpf
left a comment
There was a problem hiding this comment.
move import to top, otherwise looks good
|
|
||
| def _get_activations_batched(self, paths, layers, batch_size): | ||
| layer_activations = None | ||
| from collections import OrderedDict |
Member
There was a problem hiding this comment.
keep imports at the top of the file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original activations/core.py: ActivationsHelper._get_activations_batched, the np.concatenate for accumulating output features will drastically slow down the program (as the accumulated result becomes larger). Now I fix it by simply using list to keep track of all outputs and concatenate them at the very end.