Include query parameters in dictionary notation#13
Open
roshow wants to merge 3 commits intobraindamageinc:masterfrom
Open
Include query parameters in dictionary notation#13roshow wants to merge 3 commits intobraindamageinc:masterfrom
roshow wants to merge 3 commits intobraindamageinc:masterfrom
Conversation
Owner
|
Hi, thanks for the update. i will merge as soon as possible (made some changes recently and i need to merge by hand). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an update to http_requester.py so you can put in the parameters for a request on a separate line from the url. So, for example, instead of:
GET http://www.youtube.com/results?search_query=batman&filters=hd
You can write it like this:
GET http://www.youtube.com/results
{ 'search_query': 'batman', 'filters': 'hd' }
Note that for this to work, you have to write the dictionary in one line without breaks. The dictionary can be written in any line following the url -- I have the script looking for anything that begins with curly brackets.
You can find my comments in the code by searching for "#roshow"
Thanks for this plugin! It's a big help.