Skip to content

ci: add ready_for_review trigger to PR validation workflow#97

Merged
GoogilyBoogily merged 1 commit into
mainfrom
fix-pr-validation-draft-trigger
May 12, 2026
Merged

ci: add ready_for_review trigger to PR validation workflow#97
GoogilyBoogily merged 1 commit into
mainfrom
fix-pr-validation-draft-trigger

Conversation

@GoogilyBoogily
Copy link
Copy Markdown
Contributor

@GoogilyBoogily GoogilyBoogily commented May 11, 2026

Summary of changes

  • Add ready_for_review to the pull_request event types in the PR validation workflow
  • When a draft PR is converted to ready-for-review, GitHub fires the ready_for_review activity type. Without this type in the trigger list, the workflow never re-runs and PR validation checks stay permanently skipped.

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@GoogilyBoogily

Reviewers

@braintree/team-sdk-js

When a draft PR is converted to ready-for-review, the ready_for_review
event fires but the workflow was not configured to listen for it. This
caused PR validation checks to remain in a skipped state permanently.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the repository’s PR title validation workflow re-runs when a draft pull request is converted to “ready for review,” preventing the check from staying permanently skipped.

Changes:

  • Add the ready_for_review activity type to the pull_request trigger list for the PR title check workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@RickeySerna RickeySerna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅 👍

@GoogilyBoogily GoogilyBoogily merged commit 77a1e43 into main May 12, 2026
11 checks passed
@GoogilyBoogily GoogilyBoogily deleted the fix-pr-validation-draft-trigger branch May 12, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants