Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions benches/bench_cosmetic_matching.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
use adblock::Engine;
use criterion::*;

#[path = "../tests/test_utils.rs"]
mod test_utils;

pub fn make_engine() -> Engine {
use adblock::resources::Resource;

let rules = test_utils::rules_from_lists(&["data/brave/brave-main-list.txt"]);
let rules = adblock::test_utils::rules_from_lists(&["data/brave/brave-main-list.txt"]);
let resource_json = std::fs::read_to_string("data/brave/brave-resources.json").unwrap();
let resource_list: Vec<Resource> = serde_json::from_str(&resource_json).unwrap();
let mut engine = Engine::from_rules_parametrised(rules, Default::default(), true, true);
Expand Down
4 changes: 1 addition & 3 deletions benches/bench_matching.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ use adblock::request::Request;
use adblock::url_parser::parse_url;
use adblock::{Engine, FilterSet};

#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

#[allow(non_snake_case)]
#[derive(Serialize, Deserialize, Clone)]
Expand Down
4 changes: 1 addition & 3 deletions benches/bench_memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ use adblock::request::Request;
use adblock::resources::Resource;
use adblock::Engine;

#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

// Custom allocator to track memory usage
#[global_allocator]
Expand Down
4 changes: 1 addition & 3 deletions benches/bench_rules.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ use once_cell::sync::Lazy;

use adblock::{Engine, FilterSet};

#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

static DEFAULT_LISTS: Lazy<Vec<String>> =
Lazy::new(|| rules_from_lists(&["data/easylist.to/easylist/easylist.txt"]).collect());
Expand Down
4 changes: 1 addition & 3 deletions benches/bench_serialization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ use criterion::*;

use adblock::Engine;

#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

fn serialization(c: &mut Criterion) {
let mut group = c.benchmark_group("blocker-serialization");
Expand Down
4 changes: 1 addition & 3 deletions benches/bench_url.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ use serde::{Deserialize, Serialize};
use adblock::request::Request;
use adblock::url_parser::parse_url;

#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

#[allow(non_snake_case)]
#[derive(Serialize, Deserialize, Clone)]
Expand Down
2 changes: 1 addition & 1 deletion src/filters/fb_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::flatbuffers::containers::flat_serialize::{FlatBuilder, FlatSerialize,
use crate::flatbuffers::unsafe_tools::VerifiedFlatbufferMemory;
use crate::utils::Hash;

use super::flat::fb;
use super::flatbuffer_generated::fb;

#[derive(Clone, Default)]
pub(crate) struct ShareableString {
Expand Down
2 changes: 1 addition & 1 deletion src/filters/fb_network_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use crate::network_filter_list::token_histogram;
use crate::optimizer;
use crate::utils::{to_short_hash, Hash, ShortHash};

use super::flat::fb;
use super::flatbuffer_generated::fb;

pub(crate) enum NetworkFilterListId {
Csp = 0,
Expand Down
13 changes: 1 addition & 12 deletions src/filters/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@ pub(crate) mod fb_network_builder;
pub(crate) mod filter_data_context;
pub mod network;

#[allow(unknown_lints)]
#[allow(
dead_code,
clippy::all,
unused_imports,
unsafe_code,
mismatched_lifetime_syntaxes
)]
#[path = "../flatbuffers/fb_network_filter_generated.rs"]
mod flat;

pub(crate) mod flatbuffer_generated {
pub use super::flat::fb;
pub use crate::flatbuffers::fb_network_filter_generated::fb;
}
10 changes: 10 additions & 0 deletions src/flatbuffers/mod.rs
Original file line number Diff line number Diff line change
@@ -1,2 +1,12 @@
pub(crate) mod containers;
pub(crate) mod unsafe_tools;

#[allow(unknown_lints)]
#[allow(
dead_code,
clippy::all,
unused_imports,
unsafe_code,
mismatched_lifetime_syntaxes
)]
pub(crate) mod fb_network_filter_generated;
5 changes: 1 addition & 4 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ mod optimizer;
pub mod regex_manager;
pub mod request;
pub mod resources;
pub mod test_utils;
pub mod url_parser;

#[doc(hidden)]
Expand All @@ -42,10 +43,6 @@ pub use engine::Engine;
#[doc(inline)]
pub use lists::FilterSet;

#[cfg(test)]
#[path = "../tests/test_utils.rs"]
mod test_utils;

#[cfg(test)]
mod sync_tests {
#[allow(unused)]
Expand Down
4 changes: 2 additions & 2 deletions tests/test_utils.rs → src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Convenience functions used for tests across different build targets. Import via `#[path = ]` if
//! needed outside of this directory.
//! Test helper utilities for the adblock-rust project.
//! Used in tests and benchmarks.

#[cfg(not(target_arch = "wasm32"))]
pub fn rules_from_lists(
Expand Down
4 changes: 1 addition & 3 deletions tests/matching.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@ fn check_engine_matching() {
#[test]
#[cfg(not(debug_assertions))] // This test is too slow to run in debug mode
fn check_rule_matching_browserlike() {
#[path = "../tests/test_utils.rs"]
mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

use adblock::request::Request;
use adblock::Engine;
Expand Down
3 changes: 1 addition & 2 deletions tests/ublock-coverage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ use adblock::Engine;
#[allow(unused_imports)]
use std::collections::HashMap;

mod test_utils;
use test_utils::rules_from_lists;
use adblock::test_utils::rules_from_lists;

#[cfg(not(debug_assertions))]
#[allow(non_snake_case)]
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/engine.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#[cfg(test)]
mod tests {
use super::super::*;
use crate::lists::FilterFormat;
use crate::resources::MimeType;
use crate::{lists::FilterFormat, test_utils::rules_from_lists};
use crate::test_utils::rules_from_lists;
use base64::{engine::Engine as _, prelude::BASE64_STANDARD};
use seahash::hash;

Expand Down