Skip to content

[NTP] Increase the max number of custom top sites to 120 (uplift to 1.85.x) #32377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brave-builds wants to merge 1 commit into from
Closed

[NTP] Increase the max number of custom top sites to 120 (uplift to 1.85.x) #32377

brave-builds wants to merge 1 commit into from

Conversation

@brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 18, 2025

Uplift of #32043
Resolves brave/brave-browser#50468

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 18, 2025 01:40
@brave-builds brave-builds requested a review from a team as a code owner November 18, 2025 01:40
@brave-builds brave-builds added this to the 1.85.x - Beta milestone Nov 18, 2025
@brave-builds brave-builds added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 18, 2025
@brave-builds brave-builds self-assigned this Nov 18, 2025
@brave-builds
Copy link
Collaborator Author

brave-builds commented Nov 18, 2025

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll let this one ride the trains via 1.86.x as the above only affects a small amount of users re: wanting more custom top sites via NTP compared to the current default which is 48. Most users won't even get to 48 custom top sites. As discussed with @rebron @bsclifton, we'll let this one ride the trains.

@kjozwiak kjozwiak closed this Nov 18, 2025
@kjozwiak kjozwiak deleted the pr32043_ksmith-ntp-48-top-sites_1.85.x branch November 18, 2025 20:18
@kjozwiak kjozwiak removed this from the 1.85.x - Beta milestone Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels

CI/storybook-url Deploy storybook and provide a unique URL for each build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brave-builds @kjozwiak