Skip to content

Conversation

@fallaciousreasoning
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1006.pr.nala.bravesoftware.com/
✅ Commit preview: https://1006.pr.nala.bravesoftware.com/commit-437f0ec1a2da7290252b4f81e12aad67c568b750/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2025-02-26 22:03:46.357132345 +0000
+++ ./tokens/css/variables-android.css	2025-02-26 22:03:05.386940183 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2025-02-26 22:03:46.601133318 +0000
+++ ./tokens/css/variables-browser.css	2025-02-26 22:03:05.366940071 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2025-02-26 22:03:46.826134213 +0000
+++ ./tokens/css/variables-ios.css	2025-02-26 22:03:05.407940300 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2025-02-26 22:03:47.075135202 +0000
+++ ./tokens/css/variables-marketing.css	2025-02-26 22:03:05.431940434 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2025-02-26 22:03:47.296136082 +0000
+++ ./tokens/css/variables-news.css	2025-02-26 22:03:05.462940608 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2025-02-26 22:03:47.533137025 +0000
+++ ./tokens/css/variables-newtab.css	2025-02-26 22:03:05.472940663 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2025-02-26 22:03:47.752137896 +0000
+++ ./tokens/css/variables-search.css	2025-02-26 22:03:05.454940563 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2025-02-26 22:03:47.973138775 +0000
+++ ./tokens/css/variables-web3.css	2025-02-26 22:03:05.481940714 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2025-02-26 22:03:48.331140200 +0000
+++ ./tokens/css/variables.css	2025-02-26 22:03:05.215939227 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Copy link
Collaborator

@AlanBreck AlanBreck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want this. For instance, in landscape mode on mobile, we want the dialog to scroll.

@fallaciousreasoning
Copy link
Collaborator Author

I think the whole Dialog should scroll, but the content of the dialog shouldn't scroll

@AlanBreck
Copy link
Collaborator

I think the whole Dialog should scroll, but the content of the dialog shouldn't scroll

I agree, but this makes it so the dialog won't scroll, yes? Try viewing one of the stories in landscape mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants