Allow query options to be set on each Statement object #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodabrew
force-pushed
the
stmt_options
branch
2 times, most recently
from
efbf12a to
bc5097c
Compare
sodabrew
force-pushed
the
stmt_options
branch
from
bc5097c to
a8240d6
Compare
sodabrew
force-pushed
the
stmt_options
branch
3 times, most recently
from
3db24ce to
d5d050a
Compare
sodabrew
force-pushed
the
stmt_options
branch
from
d5d050a to
2489856
Compare
Collaborator
Author
|
@jeremyevans Thanks for bringing this issue up in #774. I've hesitated on this PR because I wasn't sure if it was actually needed, or if it even made sense to store different query options into each statement. It's also not obvious to me whether a change to query options on the Client itself should override the options on a Statement that was created previously. Your feedback as a user greatly appreciated! |
sodabrew
force-pushed
the
stmt_options
branch
2 times, most recently
from
88ea788 to
3bfc12a
Compare
sodabrew
force-pushed
the
stmt_options
branch
from
3bfc12a to
977b098
Compare
Collaborator
Author
|
Closing in favor of #912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Prepared Statements API didn't provide a way to pass query options into the prepare or execute phase of a statement. Rather, you'd have to modify the query options on the Client object prior to each Statement#execute.
In this PR, I've added a query options argument to Client#prepare, analogous to Client#query, and save a copy of these options into the Statement object, to be used for each Statement#execute.
I sort of wish the options were on Statement#execute, but I can't think of any way to differentiate between "argument that is supposed to be a ? replacement" and "argument that is the options hash".