PCBC implementation + incrBytes() for C-PCBC implementation #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thank you for the MR, I will test it soon |
bricke
requested changes
Dec 5, 2022
Owner
bricke
left a comment
bricke
left a comment
There was a problem hiding this comment.
Hi, can you remove your .user file and add some testing for this new modes?
Author
i'm sorry I can't add those to my MR, I failed at making the test units :( |
Owner
|
I can try making them myself |
Author
|
That would be perfect, block cipher mode implementation is easier than copying test units coding standarts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.