feat: Postgres array editor, keyring persistence fix, table styles & UI polish - #48
Closed
broisnischal wants to merge 2 commits into
Closed
feat: Postgres array editor, keyring persistence fix, table styles & UI polish#48broisnischal wants to merge 2 commits into
broisnischal wants to merge 2 commits into
Conversation
…UI polish Rebased from feat/impfixes onto master (the original 'chore: working on capacitor' commit — misnamed; it carries finished features, not capacitor). Dropped stray .claude/phobos-* tooling files. - Postgres array columns: decode varchar[]/int[]/… into JSON arrays (was garbage bytes), with a dedicated Prisma-style ArrayCellEditor (add/remove/ reorder) that writes a cast array literal. - Keyring: enable per-platform backend features so saved credentials actually persist (v3 without a backend silently used a non-persistent in-memory mock). - Data table: 6 selectable grid styles (lines/bordered/striped/dotted/dots/minimal). - Editable prettified DML preview before apply; auto-reconnect on startup. - More keyboard shortcuts (reopen tab, go-to-tab 1–9, toggle tab bar, disconnect). - Connection screen / provider sign-in polish.
🦋 Changeset detectedLatest commit: 9449f62 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
Author
|
Superseded by #49 (consolidated release PR, labeled release:minor → v1.12.0). All changes from this PR are included there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases the stranded
feat/impfixesbranch onto current master and opens it as a reviewable PR. The original single commit was misnamedchore: working on capacitor— it actually carries finished features (no capacitor code). It was 9 commits behind master and had never been PR'd.Cleanup applied during rebase: dropped stray tooling files that were committed by mistake (
.claude/phobos-benchmark.jsonl,.claude/phobos-state.md,src-tauri/.claude/phobos-state.md).What's included
Postgres array support (the "array in datatable" fix)
query.rs— decode array columns (varchar[]/int[]/…) into JSON arrays. Previously they fell through to a raw-bytes path that reinterpreted Postgres's binary array wire format as UTF-8 → garbage□boxes.ArrayCellEditor.svelte(new) — Prisma-Studio-style add / remove / reorder / insert editor for array cells; writes a cast Postgres array literal ({a,b}).DataTable.svelte— wiring +{a,b}display, gated to Postgres/CockroachDB.Keyring persistence fix
Cargo.toml/secrets.rs— enable per-platform keyring backends (apple-native,windows-native,sync-secret-service,crypto-rust). Without a backend feature, keyring v3 silently uses a non-persistent in-memory mock (writes return Ok but read back empty).Data table & UX
Verification
cargo check --no-default-featuresclean (keyring recompiled with new backend features).npm run buildclean.ProviderConnect.sveltewith the sign-in button change already in master; I verified the merged button region by hand.Notes
release:minorlabel when you want to cut the release (per your usual flow — I left it off so it doesn't auto-release on merge).origin/feat/impfixesis left untouched (no force-push); this is a freshfeat/impfixes-rebasebranch.