fix: close daemon health probe socket#492
Open
SUJALMU2004 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_daemon()during the warm daemon health probeWhy
ensure_daemon()probes a live daemon withTarget.getTargetsbefore returning. On the healthy path it returned immediately without closing the socket, which can leak descriptors in long-lived agent processes that callensure_daemon()repeatedly.Tests
python -m pytest -q tests\unit\test_admin.py::test_ensure_daemon_closes_probe_socket_when_daemon_is_healthypython -m compileall -q src testspython -m pytest -q tests\unit\test_admin.py -k "not preserves_snap_bin"Summary by cubic
Fixes a file descriptor leak in the daemon health probe and adds a regression test for the healthy path.
Written for commit 4157162. Summary will update on new commits.