ci: avoid rerunning TypeScript unit tests - #2985
Merged
miguelg719 merged 1 commit intoSep 19, 2026
Merged
Conversation
Contributor
|
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run. |
miguelg719
approved these changes
Sep 19, 2026
Contributor
|
The latest approval by @miguelg719 could not refresh the mirrored PR automatically (push-failed). The external PR stays open, and the mirrored PR should be updated manually before work continues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The TypeScript unit job currently runs
turbo run test:unitand then runs rootvitest run. The second command repeats the package unit tests, so this change removes it along with the unused Chrome output ID.Chrome setup and the separate browser job remain unchanged.
The baseline repeated root Vitest step took 81 seconds after Turbo unit tests had already completed. With this change, the TypeScript unit job took 2m 53s, compared with 4m 16s in the baseline.
Coverage check
We verified that removing the root Vitest run does not drop the relevant unit coverage:
test:unittasks collect 240.packages/sdk-ts/tests/browser-runtime, which is already covered by the separatetest:browsertask.BROWSERBASE_SMOKE=1.test:unitcommand rather than replacing it with the root config.Validation
On a branch based on the current upstream
main:pnpm install --frozen-lockfilepassedpnpm build— 14 tasks passedpnpm check— 36 tasks passedpnpm exec turbo run test:unit— 33 tasks passedThe only fork limitation is the Browserbase smoke test, which requires
BROWSERBASE_API_KEY.Summary by cubic
Removes the duplicate root
vitest runstep from the TypeScript unit job so package unit tests run only once. The browser-runtime specs that root Vitest picked up are already covered by thebrowser-tsjob, so coverage is unchanged.Written for commit de3f999. Summary will update on new commits.