AXE-3625: Combined axe-core bulk-review (superset #244 + confirmed subset #245)#257
Open
rajathmr2000 wants to merge 16 commits into
Open
AXE-3625: Combined axe-core bulk-review (superset #244 + confirmed subset #245)#257rajathmr2000 wants to merge 16 commits into
rajathmr2000 wants to merge 16 commits into
Conversation
Wire seven axe-core rules to their Phase 2 bulk-review categories via metadata.defaultCategory (reference data only; no rule logic change): aria-hidden-focus -> aria-hidden aria-valid-attr-value -> aria-attributes bypass -> bypass-blocks css-orientation-lock -> orientation duplicate-id-aria -> duplicate-ids identical-links-same-purpose -> link-consistency video-caption -> media-captions Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add reviewPayload.visualHelperData emits for aria-valid-attr-value, aria-hidden-focus, identical-links-same-purpose and duplicate-id-aria (dedicated evaluate/after), plus their unit specs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collapse the dedicated duplicate-id-aria evaluate/after back into the shared duplicate-id-evaluate/duplicate-id-after, gated by a `reviewPayload` check option. The aria check enables the bulk-review payload via that option; the static/active checks keep their original string `data` and are behaviourally unchanged. Adds tests for both data shapes and verdict parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Wire metadata.defaultCategory for the prioritized rules (aria-valid-attr-value, video-caption, bypass, css-orientation-lock) and emit reviewPayload.visualHelperData for aria-valid-attr-value. Excludes aria-hidden-focus / identical-links-same-purpose / duplicate-id-aria (deferred). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update the 8 needs-review deepEqual expectations in valid-attr-value.js to include the reviewPayload the check now emits on the needs-review path, and add the // a11y-rule-aria-valid-attr-value tag on the emit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Normalize the // a11y-rule comment indentation (tab -> spaces) so fmt:check (prettier --check) passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e PR # Conflicts: # lib/checks/aria/aria-valid-attr-value-evaluate.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final combined axe-core branch for the Phase-2 bulk-review work: the superset (#244) plus the confirmed/tested subset (#245) merged in, so future rule inclusions land on one branch. Built on top of #244 (which stays untouched as its own ready PR).
Background
defaultCategory+ DRY refactor) — ready, not modified.This branch =
#244with#245merged in. #244 is already a functional superset of #245, so the only content delta from #244 is a one-line explanatory comment carried over from #245's confirmed version ofaria-valid-attr-value-evaluate.js; the merge also records #245's provenance.Changes
feat/AXE-3625-bulk-review-priority(feat: reviewpayload priority rules (axe-core) #245) into a branch based onfeat/AXE-3625-phase-2-bulk-review(feat: Add defaultCategory to Phase 2 bulk-review rules #244).lib/checks/aria/aria-valid-attr-value-evaluate.js) resolved toward feat: reviewpayload priority rules (axe-core) #245 — identical emit logic, plus thea11y-rule-aria-valid-attr-valuecomment.Verification
npm run build(grunt) succeeds —axe.jsgenerated.Notes
🤖 Generated with Claude Code