Draft
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=992Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 46.27% 45.90% -0.38%
==========================================
Files 360 374 +14
Lines 62584 63818 +1234
Branches 62584 63818 +1234
==========================================
+ Hits 28961 29293 +332
- Misses 32108 32978 +870
- Partials 1515 1547 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an arch review for the moderator core.
There will be another PR to bind existing code and make use of new component.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
Yes: added ban config and journal storage duration (with defaults)
BLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Full. Added new column families in mempool db
SPECIAL DEPLOYMENT ACTIONS
Not Required
PERFORMANCE IMPACT
No impact expected
TESTS
Unit Tests
Added some tests for basic units
Network Tests
No coverage
Manual Tests
transfers-30k, simulator
Notes/Additional Comments: