Skip to content

Smaller static#3

Open
Miha-x64 wants to merge 2 commits into
brsanthu:masterfrom
Miha-x64:smaller-static
Open

Smaller static#3
Miha-x64 wants to merge 2 commits into
brsanthu:masterfrom
Miha-x64:smaller-static

Conversation

@Miha-x64

@Miha-x64 Miha-x64 commented Mar 3, 2018

Copy link
Copy Markdown

Consuming less memory:
— replaced char[64] Base64.CA and byte[64] Base64IO.CA with a single shared byte[64] (-128 bytes)
— replaced int[256] Base64.IA with byte[256] (-768 bytes);
— removed some int-to-byte narrowing casts, added byte-to-char expanding ones.
Speed test is running a bit faster on my machine — 12 seconds instead of 13.

@brsanthu

brsanthu commented Apr 1, 2018

Copy link
Copy Markdown
Owner

Hi, this is replica of code from other original source (but not treated as a fork). I would be hesitant to make this change here. Can you please propose this change in the original repo and then I can copy the change here?

@Miha-x64

Miha-x64 commented Apr 2, 2018

Copy link
Copy Markdown
Author

Hello.
Project at SourceForge does not look very alive.
Last release was in 2004, feature requests from 2007 and 2009 are still open.

@brsanthu

brsanthu commented Apr 2, 2018

Copy link
Copy Markdown
Owner

Thank you for your feedback. May be, will merge this and release as new version along with new test PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants