Smaller static#3
Open
Miha-x64 wants to merge 2 commits into
Open
Conversation
Owner
|
Hi, this is replica of code from other original source (but not treated as a fork). I would be hesitant to make this change here. Can you please propose this change in the original repo and then I can copy the change here? |
Author
|
Hello. |
Owner
|
Thank you for your feedback. May be, will merge this and release as new version along with new test PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming less memory:
— replaced
char[64] Base64.CAandbyte[64] Base64IO.CAwith a single sharedbyte[64](-128 bytes)— replaced
int[256] Base64.IAwithbyte[256](-768 bytes);— removed some int-to-byte narrowing casts, added byte-to-char expanding ones.
Speed test is running a bit faster on my machine — 12 seconds instead of 13.