fix run_command() to handle passed versions correctly#148
Open
KiriakosGeorgiou wants to merge 1 commit intobucardo:masterfrom
Open
fix run_command() to handle passed versions correctly#148KiriakosGeorgiou wants to merge 1 commit intobucardo:masterfrom
KiriakosGeorgiou wants to merge 1 commit intobucardo:masterfrom
Conversation
… postgres, but run_command() does not correctly implement such multiple '>' or '<' version checks. run_command() should match the highest '<' or '>' version. The modified implementation works if and only if the versions are passed in ascending order, which is the way check_txn_idle() currently passes them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_txn_idle() introduced multiple '>' version ckecks to handle v10 postgres, but run_command() does not correctly implement such multiple '>' or '<' version checks.
run_command() should match the highest '<' or '>' version.
The modified implementation works if and only if the versions are
passed in ascending order, which is the way check_txn_idle() currently passes them.