test: exercise real production wiring in acp/daemon memory-loop tests - #6179
Merged
Conversation
github-actions
Bot
added
tests
bug-ops
force-pushed
the
fix/6170-acp-daemon-loop-test-wiring
branch
from
July 12, 2026 21:37
df48698 to
58e07d2
Compare
github-actions
Bot
added
tests
bug-ops
enabled auto-merge (squash)
July 12, 2026 21:38
bug-ops
force-pushed
the
fix/6170-acp-daemon-loop-test-wiring
branch
from
July 12, 2026 21:39
58e07d2 to
e614566
Compare
github-actions
Bot
added
tests
acp.rs and daemon.rs regression tests reconstructed the memory-maintenance- loop spawn blocks with a mock TaskSupervisor instead of calling the real production wiring, so a broken config gate would go undetected. Extract the wiring into standalone functions mirroring serve/deps.rs's existing pattern and have both tests call them directly.
The function extracted in #6170 was missing the #[cfg(feature = "acp")] gate that its call sites (build_acp_deps, the regression test) already carry, so it compiled unconditionally and failed to resolve AppBuilder under feature bundles without acp/acp-http (bench, desktop, server, chat).
bug-ops
force-pushed
the
fix/6170-acp-daemon-loop-test-wiring
branch
from
July 12, 2026 21:57
e614566 to
2d06014
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/acp.rs'sacp_memory_maintenance_loops_registered_on_connection_supervisorandsrc/daemon.rs'sdaemon_memory_maintenance_loops_registered_on_mem_supervisorregression tests reconstructed the memory-maintenance-loop spawn blocks inline with a mockTaskSupervisor, rather than invoking the real production wiring path (build_acp_deps/run_daemon). A broken or invertedconfig.memory.*.enabledguard in production would go undetected by either test.spawn_acp_memory_maintenance_loops(src/acp.rs) andspawn_daemon_memory_maintenance_loops(src/daemon.rs) functions, mirroring the existingspawn_memory_maintenance_loopspattern already used insrc/serve/deps.rs. Bothbuild_acp_deps/run_daemonnow call the extracted functions, and both regression tests now call them directly instead of reconstructing the spawn logic.TaskSupervisor::spawn.Closes #6170
Test plan
config.memory.*.enabledguard inside the extracted functions now causes the corresponding regression test to fail, and that reverting restores a clean passcargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins— 13253 passed, 35 skippedRUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"origin/main(picked up test: guard workspace linker_messages=allow against silent removal #6171/fix(commands): close command-list drift between COMMANDS, registries, and TUI autocomplete #6172/fix: unify skill/plugin registry disabled-state messaging #6174) and re-ran the full check suite clean