Repository navigation
fix(xdebug-trace): drop xdebug-trace from the UI menu when its temp dir cannot be made - #413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #412 (Xdebug Trace v1, GitHub #288). In memory mode, when the trace temp dir cannot be made, the module already stays unregistered and logs why, but
/api/settingsstill listedxdebug-trace: the UI showed «Xdebug traces» and uploads fell through to http-dump.ModulesConfig.Disable(type)turns a module off at runtime;IsEnabledandDisableshare one type → field switch.main.go: on the temp dir error,cfg.Modules.Disable("xdebug-trace")beforeapp.New, soEnabledTypes(the UI menu) drops it.Tests
TestModulesConfig_Disable: disabled type is off and missing fromEnabledTypes, unknown type is a no-op.go vet+go test -race -count=1 ./internal/app/ ./modules/xdebugtrace/ok.TMPDIR=/nonexistent-dirandvar-dump: false→ logxdebug-trace: cannot create temp dir; module disabled,/api/settingseventswithoutxdebug-trace.Base: master (after #412, merged).