Modified the docs/docs-using-js-api-support.md file and the docs/docs-using-extending.md file#1062
Modified the docs/docs-using-js-api-support.md file and the docs/docs-using-extending.md file#1062AyzeLYC wants to merge 10 commits intobytecodealliance:mainfrom
Conversation
|
in case someone ask, nope the description isn't AI generated, i'm French and it's the reason why the description is verry basic |
saulecabrera
left a comment
There was a problem hiding this comment.
Thanks for the PR -- the TextEncoder duplication piece makes sense to me and
You'll need a WIT file in `wit/world.wit` that looks like the following code:
as well, however, I'm not sure if the other changes improve readability, as they are only changing the space between the sentence and the colon. Perhaps you could revert those?
the line where there's the textencoder duplication doesn't make sense for me because you know, it doesn't need to be there twice but for the rest it's mostly about making the docs and everything easier for peoples eyes since if someone spends 10 hours in a row trying to understand the entire repository it will end up being really tiring after a bit ( example : the express repository ) |
|
i'll modify the files if you want but it's mostly to make it easier for peoples to read if they've been reading all the docs and the code for a long time |
Rewording my feedback: the change makes sense to me, not the duplication, sorry for the confusion. |
|
To be more explicit, the following changes make sense to me:
Except for the extra space before the colon. For the rest of the changes I think we can omit them, as they pretty much only change the spacing between the sentence and the colon. |
docs/docs-using-extending.md
Outdated
| initialization process. | ||
|
|
||
| Your `Cargo.toml` should look like: | ||
| Your `Cargo.toml` should look like the following data : |
There was a problem hiding this comment.
| Your `Cargo.toml` should look like the following data : | |
| Your `Cargo.toml` should look like the following: |
|
i just changed the files like necessary, you can push this pull request if you want, i'll check for some upgrades that can be done to some of the js code of the repo and then i'll make a new pull request |
My pull request isn't of high priority.
In my different modifications i :
Removed the line |
TextEncoder|🚧| Partial support, not fully compliant| in docs/docs-using-js-api-support.md ( that line was in the file twice )Added a few more words in docs/docs-using-extending.md to make the informations easier to understand for peoples that are not native english speakers