winch(aarch64): v128 ABI plumbing#13948
Merged
alexcrichton merged 1 commit intoJul 24, 2026
Merged
Conversation
cfallin
approved these changes
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
Member
|
ok that one ^ seems legitimate (unlike so many others 😢) |
macovedj
force-pushed
the
winch-aarch64-v128-abi
branch
from
July 23, 2026 22:18
2c8ce8f to
e31d876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While observing which tests flip as we add simd instructions for #9925, it became clear that while the instructions become usable, the simd types still error
Unsupported Wasm Typewhen they appear in function signatures. I was able to reproduce the logic into_abi_operandfrom the x64 implementation to use vector registers and larger stack slots for V128. This removes the error from the included .wat files, and flips a number of tests that should have flipped from the simd instructions that have been implemented so far.