fix(gcp): add pub visibility and fix borrow errors in gcp_storage.rs#7
Open
ayuxsh009 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix(gcp): add pub visibility and fix borrow errors in gcp_storage.rs#7ayuxsh009 wants to merge 1 commit intoc2siorg:mainfrom
ayuxsh009 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes compilation errors in the GCP storage module by adding public visibility modifiers and resolving borrow checker violations. The changes enable the GoogleStorage struct and its methods to be accessible from test modules while ensuring that temporary values live long enough during HashMap construction.
Changes:
- Added
pubvisibility modifiers toGoogleStoragestruct and its methods (new,create_disk,delete_disk,create_snapshot) - Fixed borrow checker errors by storing formatted string values in local variables before inserting references into the HashMap
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Summary
This PR fixes build failures in the GCP storage module caused by visibility issues and borrow checker violations.
Problem
The project failed to compile due to the following errors:
E0425 / E0433
GoogleStoragewas not accessible from test modules because it lackedpubvisibility.E0716
Temporary
Value::Stringvalues were dropped while still borrowed duringHashMapinsertion.These errors prevented successful compilation and test execution.
Changes Made
Visibility Fixes
GoogleStoragestruct publicnew()constructor publiccreate_disk()method publicBorrow Checker Fix
HashMapTesting
cargo build→ success