FEATURE: Add PnL metrics #2337
Open
FEATURE: Add PnL metrics #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboyliao
force-pushed
the
dboy/strategy/pnl-metrics
branch
from
85aadc4 to
7b1b9b8
Compare
dboyliao
force-pushed
the
dboy/strategy/pnl-metrics
branch
from
7b1b9b8 to
f20d000
Compare
c9s
reviewed
Nov 25, 2025
| p.Lock() | ||
| defer p.Unlock() | ||
|
|
||
| return p.lastPrice |
Owner
There was a problem hiding this comment.
how do you handle expired last price?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.