-
-
Notifications
You must be signed in to change notification settings - Fork 54
feat: add tag.output to manage the tag output #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think you can simply set |
|
No, because the repo has 56 modules in it needing the tag prefix since they
are released independently and when I tried setting the tag pattern with no
tag prefix it complained about not finding any matching tags to version bump
|
|
maybe then we split Or even make it a slice, so it could have |
I like this, but will do |
|
Updated and it ended up being |
* tag.strip-prefix is required for mono repo structures
if I need to run
```shell
svu n --tag.prefix foo/v --tag.pattern 'foo/v*' --log.directory foo > foo/.version
svu n --tag.prefix bla/v --tag.pattern 'bla/v*' --log.directory bla > bla/.version
export BLA_NEXT=$(cat bla/.version)
export FOO_NEXT=$(cat foo/.version)
docker tag foo foo:${FOO_NEXT}
docker tag bla bla:${BLA_NEXT}
```
I do not want FOO and BLA _NEXT to have the prefix
* added --config to be able to have multiple config files to make monorepo usage easier
a245550 to
4375d95
Compare
|
@aymanbagabas I think you use this with monorepos as well, wanna give this a look? |
I still use this wrapper script to achieve this #!/usr/bin/env bash
root=$(git rev-parse --show-toplevel)
if [ "$PWD" != "$root" ]; then
prefix=$(echo -n "$PWD" | sed "s|$root/||g")
svu --tag.prefix="$prefix/v" --tag.pattern="$prefix/*" "$@"
else
svu "$@"
fi |
|
@aymanbagabas would #224 (comment) help? It is similar, but lets you define the prefix in the config for each module in the mono repo. |
tag.output is required for mono repo structures if I need to run
I do not want FOO and BLA _NEXT to have the prefix. So now I can do
fixes consider making config an argument #203
--configto be able to have multiple config files to make monorepo usage easierfixes Support monorepo #224 allowing you to specify the config to use and which directories are used to calculate versions
I made sure the
log.directoryconfig entry works as relative to the config path so you can doui-service/.svu.yml->OR
.ui-service.svu.yml->