Skip to content

Conversation

@yatsukhnenko
Copy link
Contributor

See https://github.com/cachewerk/relay-core/issues/1202

php run --warmup 0 --workers 1 --filter RelayTable\|APCu BenchmarkGet.php 
Setting up on AMD Ryzen 7 4700U with Radeon Graphics (8 cores/8 threads x86_64)
Using PHP 8.3.27 (OPcache: Off, Xdebug: Off, New Relic: Off)
Connected to Redis (8.2.2) at tcp://127.0.0.1:6379


 GET  Executing 5 iterations (0 warmup) for 1.00s seconds

+------------+--------+---------+---------+--------+-------------+--------+--------+--------+
| Client     | Memory | Network | Workers | IOPS   | IOPS/Worker | rstdev | Change | Factor |
+------------+--------+---------+---------+--------+-------------+--------+--------+--------+
| APCu       | 1.41mb |    181b |       1 | 13.01M |      13.01M | ±0.28% |  0.00% |  1.00x |
| RelayTable | 1.41mb |    181b |       1 | 21.01M |      21.01M | ±1.80% | 61.49% |  1.61x |
+------------+--------+---------+---------+--------+-------------+--------+--------+--------+

Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yatsukhnenko can we move this into a dedicated case/scenario, feels wrong to merge this with GET.

Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests and linters are failing.

{
public static function flags(): int
{
return self::STRING | self::READ | self::DEFAULT;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's NOT run these by default.

But add a README entry on how to run them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants