Configurable cluster domain #306
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for cluster domains other than
cluster.local.This feels hacky, but I didn't really find a clear path to passing some variable to ReverseProxyPlugin without introducing a global.
We can probably default this to the empty string. It should be possible to resolve e.g.
kubernetes.default.svcinside a pod, because kubelet setsoptions ndots:5in/etc/resolv.conf. Making it default empty means it should work for any domain without configuration.In my case, though, I need it to be an FQDN, because I'm running caddy-ingress outside the cluster, and my stub resolver is systemd-resolved, which has explicitely rejected support for
ndots. (They deem it a security concern.) So I need an option like this.Keeping the
cluster.localdefault seemed like the path of least resistance, for now. 🙃