Repository navigation
Stop a recording from the constitution page that hosts it - #32
Merged
Merged
Conversation
The composer's Meeting group shows Stop (Dismiss once failed) while a meeting this constitution hosts records, through the board's one stop path and guard. The board harness's joined meeting folds into the workspace example's constitution. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XEBcfWbydFqYZm6DhLvCqT
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XEBcfWbydFqYZm6DhLvCqT
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XEBcfWbydFqYZm6DhLvCqT
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XEBcfWbydFqYZm6DhLvCqT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer's Meeting group on a constitution page now shows Stop (Dismiss once the recording has failed) while a meeting that constitution hosts is recording. It goes through the same
stopCurrentMeetingandMeetingStopGuardas the Desk card, via two new members onMeetingJoinControl(stop,stopRequested), and usesmeetingActionsfor the label and the disabled-while-requested state. A recording hosted by another constitution shows no Stop here.The "Meeting switch stays checked while the composer is busy" bug is not touched: it is not in this path and the fix was not obvious.
Harness:
?meeting=joinednow folds into the workspace example's constitution when?example=workspace.Gates:
npm test1539 passed,npm run buildok,node e2e/workspace.mjs114 passed / 0 failed. New integration test inDock.integration.test.tscovers Stop shown, the shared stop call, disabled after request, Dismiss when failed, hidden for another host.🤖 Generated with Claude Code
https://claude.ai/code/session_01XEBcfWbydFqYZm6DhLvCqT