Skip to content

fix: never offer the correct seed word twice when verifying #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
munzzyy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: never offer the correct seed word twice when verifying #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/view_model/verify_seed_view_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@ abstract class VerifySeedViewModelBase extends ViewModel with Store {
String get randomWord => seedWords[randomIndex];

late final List<String> randomWords = () {
final w = wordList;
w.shuffle(Random.secure());
final elms = w.take(5).toList();
elms.add(randomWord);
elms.toSet(); // in case we got a duplicate
return elms.toList()..shuffle(Random.secure());
// Copy before shuffling, wordList is shared (Bip39.english is a static).
final shuffled = List<String>.of(wordList)..shuffle(Random.secure());
// Drop the correct word so it cannot show up as a decoy as well.
final decoys = shuffled.toSet()..remove(randomWord);
return [...decoys.take(5), randomWord]..shuffle(Random.secure());
}();

bool result(final String guessedWord) {
Expand Down