Conversation
ADmad
force-pushed
the
method-templates
branch
2 times, most recently
from
bc26b50 to
0d108dc
Compare
ADmad
force-pushed
the
method-templates
branch
from
0d108dc to
bb2edcf
Compare
Member
Author
The docker build passes, so that's a good sign. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for displaying template parameter information for methods in the documentation. The changes extract @template tags from docblocks and render them in the function detail template with their bounds and default values.
- Extracts
@templatetags from docblocks and stores them in the tags array - Adds a new "Templates" section in the function detail page to display template parameters
- Displays template name, bound, and default value for each template parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Reflection/DocBlock.php | Parses and stores @template tags from docblocks |
| templates/pages/parts/function-detail.twig | Renders template parameters in a dedicated section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
othercorey
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #333
I haven't actually tried running this, so no idea if it actually works 😛