Quote database names in PostgreSQL and SQL Server adapters #1002
+33
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createDatabase()anddropDatabase()usingquoteTableName(), but PostgreSQL and SQL Server did not quote these identifiers consistently.PostgreSQL fixes:
createDatabase(): UsequoteSchemaName()for database name andquoteString()for charset encodingdropDatabase(): UsequoteSchemaName()for database nameSQL Server fixes:
createDatabase(): UsequoteSchemaName()for database name and collation instead of manual[brackets]dropDatabase(): Replace heredoc with sprintf usingquoteSchemaName()for identifiers andquoteString()for string comparisonsDocblock fixes:
@paramstypo to@paraminBaseMigration.phpforeignKey()andindex()methodsThis ensures consistent identifier quoting across all database adapters and fixes documentation errors.
Test plan