fix: avoid copying pnpm node_modules into worktrees#872
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
thymikee
force-pushed
the
fix/worktreeinclude-pnpm-node-modules
branch
from
ecf120b to
6f1d344
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid copying pnpm-managed dependency trees into Codex worktrees so pnpm can recreate its symlink/hardlink graph locally.
Also give the delayed Android fill verification regression a larger per-test timeout so the shell-backed mock can tolerate production retry delays.
Validation
Ran
git diff --check.Focused Vitest startup is currently blocked in this worktree by the existing malformed copied
node_modules:tinyglobbycannot resolvefdir.