Skip to content

test: migrate Android recording sizing coverage#876

Merged
thymikee merged 1 commit into
mainfrom
codex/recording-provider-test-cleanup
Jun 25, 2026
Merged

test: migrate Android recording sizing coverage#876
thymikee merged 1 commit into
mainfrom
codex/recording-provider-test-cleanup

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Move Android recording size-selection assertions from mock-heavy handler tests into the provider-backed daemon scenario.

  • strengthens android-recording.test.ts to cover override-size scaling and default no-scaling behavior through the request path
  • deletes two redundant mocked handler tests from record-trace.test.ts
  • touched 2 files; scope stayed within Android recording test coverage

Validation

Targeted record-trace/provider tests passed, integration progress stayed at 47/47 public commands and 56/56 device-observable flags, and lint/typecheck passed via local installed binaries because the sandboxed pnpm shim could not verify its registry signature.

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB 0 B
JS gzip 433.9 kB 433.9 kB 0 B
npm tarball 571.8 kB 571.6 kB -273 B
npm unpacked 1.9 MB 1.9 MB -658 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.6 ms 27.6 ms +0.0 ms
CLI --help 47.6 ms 47.7 ms +0.2 ms

Top changed chunks: no changes in the largest emitted chunks.

@thymikee thymikee merged commit 56d8e39 into main Jun 25, 2026
20 checks passed
@thymikee thymikee deleted the codex/recording-provider-test-cleanup branch June 25, 2026 15:33
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-25 15:34 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant