Change all instances of Fixnum to Integer. Fixes #10.#21
Open
eddieantonio wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@deartrudence Thanks for getting around to these PRs! 😄 As mentioned, this is just #20, but I resolved the merge conflicts. |
nathany
reviewed
Oct 7, 2019
|
|
||
| Heads up! Older versions of Ruby call it `Fixnum` instead of | ||
| `Integer`. For the purposes of this workshop, whenever you see | ||
| `Integer` in your code, you can safely replace it with `Fixnum`. |
There was a problem hiding this comment.
Suggest dropping this second sentence from the slides to keep it brief.
Contributor
Author
|
@deartrudence: it's done! Let's merge another PR for Hacktoberfest! |
nathany
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this is a fixed version of #20! This resolves the conflicts introduced by that PR.
Anywhere it said Fixnum, I changed to Integer. This works for all versions of Ruby 2.x, as far as I'm aware. However
42.classmay return Fixnum in older versions.I also added a quick note for people using old versions of Ruby (mostly macOS users).
Closes #10
Closes #20