Skip to content

v2: source Teller app id from link-session endpoint#1114

Merged
canalesb93 merged 1 commit into
mainfrom
fix/teller-connect-app-id
May 16, 2026
Merged

v2: source Teller app id from link-session endpoint#1114
canalesb93 merged 1 commit into
mainfrom
fix/teller-connect-app-id

Conversation

@canalesb93
Copy link
Copy Markdown
Owner

Summary

  • web/src/features/connections/connect-bank-sheet.tsx was reading the Teller application id from window.__TELLER_APP_ID__, but nothing in the codebase sets that global — every Teller connect attempt fell through to the "application id not configured" toast.
  • Flip Teller's `needsLinkSession` to `true` so the existing `LinkSessionHandler` returns the server-configured app id as `link_token` (the Teller provider's `CreateLinkSession` already returns the app id as its `Token` — see `internal/provider/teller/link.go:42`).
  • Read `session.link_token` in the connect sheet, the same way Plaid reads its link token.

Follow-up

`web/src/features/connections/reauth-sheet.tsx:158` still reads the unset window global for the Teller reauth flow. Same bug, different sheet — leaving it for a separate PR since the reauth path's `session.link_token` carries the enrollment id rather than the app id and needs a second source.

Test plan

  • `go build ./... && go vet ./...`
  • `bun run lint` (tsc --noEmit) clean
  • Updated and ran `TestListProviders_`, `TestLinkSession_Teller`, `TestGetProvider_`, `TestConnectionsReauth` — pass
  • Manual: connect a Teller account end-to-end with `TELLER_APP_ID` set
  • Manual: confirm error toast still fires when server has no Teller app id

🤖 Generated with Claude Code

Teller Connect was bootstrapped from `window.__TELLER_APP_ID__`, but
nothing sets that global — every Teller connect attempt fell through to
the "application id not configured" toast.

Flip Teller's `needsLinkSession` to true so the existing handler returns
the server-configured app id as `link_token` (the Teller provider's
`CreateLinkSession` already does this), and read it in the connect sheet
the same way Plaid reads its link token.

Note: the reauth sheet still reads the unset window global; that's a
separate follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@canalesb93 canalesb93 enabled auto-merge (squash) May 16, 2026 07:08
@canalesb93 canalesb93 merged commit 6f2694e into main May 16, 2026
9 of 10 checks passed
@canalesb93 canalesb93 deleted the fix/teller-connect-app-id branch May 16, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant