Skip to content

e2e-tests: Add tests for allowed_users broker property#1469

Open
nooreldeenmansour wants to merge 1 commit intomainfrom
e2e-tests-allowed-users
Open

e2e-tests: Add tests for allowed_users broker property#1469
nooreldeenmansour wants to merge 1 commit intomainfrom
e2e-tests-allowed-users

Conversation

@nooreldeenmansour
Copy link
Copy Markdown
Member

@nooreldeenmansour nooreldeenmansour commented Apr 16, 2026

Add tests for the following scenarios:

  • allowed_users is set to OWNER and the owner is set to the test user (login successful)
  • allowed_users is set to OWNER and owner is explicitly set to an empty value (login denied)
  • allowed_users is set to user and login with that user (login successful)
  • allowed_users set to a specific user and login with a different user (login denied)
  • allowed_users is set to to ALL (login successful)

UDENG-9543
UDENG-9544
UDENG-9545
UDENG-9546
UDENG-9547

@nooreldeenmansour nooreldeenmansour changed the title e2e-tests: Add tests for allowed_users broker config property e2e-tests: Add tests for allowed_users broker property Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.94%. Comparing base (0343a33) to head (02dc55e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
+ Coverage   80.48%   86.94%   +6.46%     
==========================================
  Files          20       93      +73     
  Lines        1030     6366    +5336     
  Branches        0      111     +111     
==========================================
+ Hits          829     5535    +4706     
- Misses        201      775     +574     
- Partials        0       56      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nooreldeenmansour nooreldeenmansour force-pushed the e2e-tests-allowed-users branch 2 times, most recently from 3a25d0d to 5034c2d Compare April 16, 2026 17:29
@nooreldeenmansour
Copy link
Copy Markdown
Member Author

Any idea why the provisioning ci jobs are failing?

This my third time doing a force push to trigger CI

@adombeck
Copy link
Copy Markdown
Contributor

Any idea why the provisioning ci jobs are failing?

This my third time doing a force push to trigger CI

The Ubuntu archive is having issues today

@adombeck
Copy link
Copy Markdown
Contributor

https://status.canonical.com/

@nooreldeenmansour nooreldeenmansour force-pushed the e2e-tests-allowed-users branch 2 times, most recently from b07f13c to caf67c7 Compare April 17, 2026 10:32
@nooreldeenmansour
Copy link
Copy Markdown
Member Author

The archive is operational now, but the CI jobs is failing because the broker snaps are failing to build. Probably related to #1470

Comment on lines +27 to +32
# Attempt to log in with remote user
Open Terminal
Start Log In With Remote User Through CLI: QR Code ${username}
Select Provider
Continue Log In With Remote User: Authenticate In External Browser
Check That Remote User Is Not Allowed To Log In
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device auth is the most time consuming and most fragile part of our e2e-tests currently. This PR adds five new tests which all perform device auth. How about we instead add a single new test which performs device auth once and then subsequently tests the various allowed_users values and for each uses local password authentication to test it.

@nooreldeenmansour nooreldeenmansour force-pushed the e2e-tests-allowed-users branch from 02dc55e to e4ddb3c Compare April 27, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants