e2e-tests: Add tests for allowed_users broker property#1469
e2e-tests: Add tests for allowed_users broker property#1469nooreldeenmansour wants to merge 1 commit intomainfrom
allowed_users broker property#1469Conversation
allowed_users broker config propertyallowed_users broker property
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
+ Coverage 80.48% 86.94% +6.46%
==========================================
Files 20 93 +73
Lines 1030 6366 +5336
Branches 0 111 +111
==========================================
+ Hits 829 5535 +4706
- Misses 201 775 +574
- Partials 0 56 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3a25d0d to
5034c2d
Compare
|
Any idea why the provisioning ci jobs are failing? This my third time doing a force push to trigger CI |
The Ubuntu archive is having issues today |
b07f13c to
caf67c7
Compare
|
The archive is operational now, but the CI jobs is failing because the broker snaps are failing to build. Probably related to #1470 |
caf67c7 to
43b8492
Compare
| # Attempt to log in with remote user | ||
| Open Terminal | ||
| Start Log In With Remote User Through CLI: QR Code ${username} | ||
| Select Provider | ||
| Continue Log In With Remote User: Authenticate In External Browser | ||
| Check That Remote User Is Not Allowed To Log In |
There was a problem hiding this comment.
The device auth is the most time consuming and most fragile part of our e2e-tests currently. This PR adds five new tests which all perform device auth. How about we instead add a single new test which performs device auth once and then subsequently tests the various allowed_users values and for each uses local password authentication to test it.
02dc55e to
e4ddb3c
Compare
Add tests for the following scenarios:
allowed_usersis set toOWNERand theowneris set to the test user (login successful)allowed_usersis set toOWNERandowneris explicitly set to an empty value (login denied)allowed_usersis set touserand login with that user (login successful)allowed_usersset to a specific user and login with a different user (login denied)allowed_usersis set to toALL(login successful)UDENG-9543
UDENG-9544
UDENG-9545
UDENG-9546
UDENG-9547