Skip to content

Conversation

@jimporter
Copy link
Contributor

This replaces a few manually-implemented comparison operators with the defaults. I guess these got missed in the big C++20 PR.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.47%. Comparing base (29afa50) to head (059b0c7).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4502      +/-   ##
==========================================
- Coverage   89.47%   89.47%   -0.01%     
==========================================
  Files         242      243       +1     
  Lines       13880    13877       -3     
==========================================
- Hits        12419    12416       -3     
  Misses       1461     1461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sploder12
Copy link
Contributor

Doesn't build on MacOS, see discussion of IPAddress comparisons on my subnet refactor PR for context

@jimporter
Copy link
Contributor Author

Doesn't build on MacOS, see discussion of IPAddress comparisons on my subnet refactor PR for context

Ah ha. Since you're already working on that, I'll just stay out of your way and remove the IPAddress change from this PR.

Copy link
Contributor

@tobe2098 tobe2098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu builds and runs the tests without problems, but Windows 11 Pro fails the test: Utils/NormalizeMountTargetTest.mountTargetsNormalizeCorrectly/3, where GetParam() = ("../..//folder","/folder"). I am unsure if this is due to this PR, since the CI pipeline has been changed to use Windows Server 2025.
After some research I found that it may be to a missing rebase to origin/main, since in main it is fixed, and the normalize target mounts utils function is different due to your commit, so I will be approving this.

Copy link
Contributor

@tobe2098 tobe2098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some research I found that it may be to a missing rebase to origin/main, since in main it is fixed, and the normalize target mounts utils function is different due to your commit, so I will be approving this.

@jimporter
Copy link
Contributor Author

After some research I found that it may be to a missing rebase to origin/main, since in main it is fixed, and the normalize target mounts utils function is different due to your commit, so I will be approving this.

Thanks. I've rebased so hopefully everything passes CI now.

@tobe2098
Copy link
Contributor

It does pass now. Great job!

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobe2098 tobe2098 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit 7752605 Nov 14, 2025
24 checks passed
@tobe2098 tobe2098 deleted the default-equal branch November 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants