Support for installing Sweet Security via pulumi - #6989
Conversation
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Let's make this configurable so we have more control about which networks we deploy this to and when 🙏
|
|
||
| configureReloader(); | ||
|
|
||
| configureSweet(); |
There was a problem hiding this comment.
Shall we make this configurable? Unlike reloader you (AFAIU) need to pay to be able to use it, so including that without an option to disable (on the public repo) seems a bit weird.
There was a problem hiding this comment.
...and also you might want to stagger the deployment so you don't risk breaking all (ci) networks at the same time?
There was a problem hiding this comment.
Yes, sorry, that was definitely my intention. Forgot to push the latest commit that actually does that 🤦
| } from '@canton-network/splice-pulumi-common'; | ||
|
|
||
| export function configureSweet(): k8s.helm.v3.Release { | ||
| const operatorNs = exactNamespace('sweet-operator', false, true); |
There was a problem hiding this comment.
Any reason not to use the same namespace for both?
There was a problem hiding this comment.
I'm just following their docs.
There was a problem hiding this comment.
I can try merging the two and seeing if something breaks I guess.
|
|
||
| export function configureSweet(): k8s.helm.v3.Release { | ||
| const operatorNs = exactNamespace('sweet-operator', false, true); | ||
| const sweetNs = exactNamespace('sweet', false, true); |
There was a problem hiding this comment.
Why retainOnDelete = true? On both namespaces?
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
|
Sorry @martinflorian-da I actually had it configurable, and fixed the retain, but apparently never pushed the latest commit. |
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Well I'm glad I passed your "is the reviewer awake" test then! Thank you!
2 participants
For now, disabled by default. Tested on a scratchnet, seems to work fine.
Part of https://github.com/DACH-NY/canton-network-internal/issues/6624
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines