Public Sequencer: Merge from main - #6994
Open
pasindutennage-da wants to merge 98 commits into
Open
Conversation
Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
[ci] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
…egrationTest (#6759) fixes DACH-NY/cn-test-failures#9517 same logic as #6432 Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Part of #5135 Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com> Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…prod tables (#6542) * added a new data stream and code to create datatransfer jobs to load prod tables Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * Added code to stop and start datastreams from config and intergrated PR comments Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * added index file changes Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * Addressed PR comments and refactured the code Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * made extra edits to bigquery.ts Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * added new boundary condition per PR comments Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * restored index and envr.envrs file Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * removed the watermark update criteria as it would always fail being less than the crrent value Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * Addresed PR comments Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * formatting Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * formatting and deleting extra coments Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * Apply suggestions from code review Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com> Signed-off-by: kajalshah-da <kajal.shah@digitalasset.com> Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * minor edits Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * minor edits- removed IAM function Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * Merged with main and fixed all diffs[ci] Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * added partition in publication per issue #6730 Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * added partition in publication per issue #6730 [ci] Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> * update expected Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> --------- Signed-off-by: Kajal Shah <kajal.shah@digitalasset.com> Signed-off-by: kajalshah-da <kajal.shah@digitalasset.com> Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com>
…veAppActivityRecordsAndTraffic` config options (#6643) This removes the `enableAppActivityRecordAndTrafficIngestion` and `serveAppActivityRecordsAndTraffic` config options and the optionality proliferation that they resulted in. --------- Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
* Re-enable `SplitwellUpgradeIntegrationTest`. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Ensure DAR is uploaded and multi-synchronizer feature flag is enabled. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Remove unneeded log assertion. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Re-enable `SplitwellUpgradeFrontendIntegrationTest` as well. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Move `splitwellUpgradeSynchronizerId` to after Alice's participant connects to that synchronizer. This fixes an issue where the `balance update and invite contracts follow group, which follows installs` test would fail when run in isolation because Alice hadn't connected to the splitwell upgrade synchronizer. When the suite was run in full, earlier tests ensured the pre-condition was met, but this prevents devs from running a command like `testOnly ... -- -z "balance update"`. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> --------- Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
[ci] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[static] Not sure if this was ever right but it doesn't work atm. Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Addresses #6448 (the splice side) --------- Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
* apply the envoy flow control to the sequencer bft endpoint [static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
* Extend splice rate limits Valid for scan and sv app Add global rate limiter (previosly we rate limited only each individual operation), which is enabled by default. Add the ability to rate limit also per ip for each oepration (disabled by default). The global rate limiter has this option enabled by default. Extend the rate limiter to check a longer interval (60s). The previous behavior was checking only the last 1s, this is still in place and works as a burst limiter, allowing for shorter burts but the longer interval enforces a lower limit for the configured interval. [ci] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
[static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
validatorWalletUsers is rendered into a HOCON fragment as
canton.validator-apps.validator_backend.validator-wallet-users.0 = {{ $user }}
unquoted, and validatorWalletUser into an env var value unquoted. Both break
for user ids that are not bare alphanumeric strings:
- '@' is not allowed in an unquoted HOCON string, so an id that is an email
address -- which some identity providers use as the user id -- produces a
config the validator app cannot parse.
- An all-digit id becomes a HOCON number rather than a string, and in the env
var case renders as a YAML integer, which is not a valid container env value.
Quote both. The surrounding code already does this elsewhere -- scanAddress
uses `| quote`, and the scan-client sv-names and seed-urls lists use
`| toJson` -- so these two sites look like oversights rather than intent.
Note for anyone who worked around this by embedding literal double quotes in
the value: those must now be removed, or the id ends up double-quoted.
Signed-off-by: Stephane Loeuillet <stephane.loeuillet@kaiko.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
… bug (#6819) [static] Signed-off-by: Mateusz Błażejewski <mateusz.blazejewski@digitalasset.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
* Extend splice rate limits Valid for scan and sv app Add global rate limiter (previosly we rate limited only each individual operation), which is enabled by default. Add the ability to rate limit also per ip for each oepration (disabled by default). The global rate limiter has this option enabled by default. Extend the rate limiter to check a longer interval (60s). The previous behavior was checking only the last 1s, this is still in place and works as a burst limiter, allowing for shorter burts but the longer interval enforces a lower limit for the configured interval. [ci] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
* Restart CometBFT when it starts replaying messages fixes #6823 [static] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * Apply suggestions from code review Co-authored-by: Martin Florian <martin.florian@digitalasset.com> Signed-off-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com> * randomize Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * snippet Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * catch all exceptions Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * Handle decreases in counter metrics [static] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * fix config [static] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> --------- Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Signed-off-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Co-authored-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com> Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com> Co-authored-by: Amanda L Martin <hythloda@gmail.com> Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Ilya Silvestrov <tellary@gmail.com>
include target host in legend and add error table with flexible filter [static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
…ers (#6964) We don't keep track of usage for the actual attribute values so the overall reported usage is actually the global usage [static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
…utting-down canton (#6958) --------- Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
See DACH-NY/canton-network-internal#6371 Regular alerts for now, plan is to promote at least some of them to sev-2 and/or sev-1 after some testing. - Discarded requests / replays <- also adds this as panels on the Global Synchronizer Utilization dashboard - Failed confirmation requests - TPS drop
* Expose sv app endpoints to the minimum users Also extend open api so the other SVs can easily apply the same restriction [static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
[ci] fixes #6970 Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
Fixes #2336 Since #2336 was filed, #4113 deprecated `scan_txlog.py` and removed the code that ran it, but #5922 added a max tap amount of 100,000,000, so the existing test code failed with a "requirement ... was not met" error. This updates the test code to instead tap the max amount. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Signed-off-by: Kajal <kajal.shah@digitalasset.com>
…6978) --------- Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
* add the configs Signed-off-by: Itai Segall <itai.segall@digitalasset.com> * [ci] done Signed-off-by: Itai Segall <itai.segall@digitalasset.com> * [ci] fmt Signed-off-by: Itai Segall <itai.segall@digitalasset.com> * [ci] cleanup Signed-off-by: Itai Segall <itai.segall@digitalasset.com> * [ci] fix the test Signed-off-by: Itai Segall <itai.segall@digitalasset.com> * [ci] Signed-off-by: Itai Segall <itai.segall@digitalasset.com> --------- Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
That warning doesn't exist in Canton anymore, see https://github.com/DACH-NY/canton/pull/30310/changes#diff-81c61bdb4b62b057717883fd710a5f662ee23d6769f03115d2db110dfda5829aL127 [ci] Fixes #2706 Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
Contributor
[backport] ReminderPlease consider backporting to the following branches:
And your PR is currently against base branch: feature-public-sequencer-and-scan. Note: Any PR comment containing [backport] will be considered for auto-backporting upon merge, |
|
Deploy upgrade pipeline triggered for Commit 0151145eda520003c57a14bd5ebc3f1f95e2769c in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/80008 |
pasindutennage-da
requested review from
krzysztofczyz-da,
martinflorian-da and
moritzkiefer-da
August 27, 2026 09:34
martinflorian-da
approved these changes
Aug 27, 2026
pasindutennage-da
force-pushed
the
pasindutennagde-da-merge-from-main-aug-27
branch
2 times, most recently
from
August 27, 2026 14:15
445fcc4 to
a2df12e
Compare
pasindutennage-da
force-pushed
the
pasindutennagde-da-merge-from-main-aug-27
branch
from
August 27, 2026 14:42
a2df12e to
b34fee4
Compare
[ci] Signed-off-by: pasindutennage-da <pasindu.tennage@digitalasset.com> Signed-off-by: Pasindu Tennage <pasindu.tennage@digitalasset.com>
pasindutennage-da
force-pushed
the
pasindutennagde-da-merge-from-main-aug-27
branch
from
August 27, 2026 15:59
0b99073 to
2eaa884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3596