fix(cli): infer delimiters for TSV inputs - #549
Open
AtomicGlance wants to merge 2 commits into
Open
Conversation
AtomicGlance
marked this pull request as ready for review
August 3, 2026 22:03
Member
|
Thanks for the PR. I'd like to hold off merging this in right now as I want to focus on getting the original PR reviewed and merged. I'll leave it be for now, but maybe get you to do a rebase/alteration once we are ready to move forward with this. |
fdosani
force-pushed
the
agent/infer-cli-delimiters
branch
from
August 6, 2026 16:02
ca983d9 to
5bb6692
Compare
fdosani
reviewed
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #545.
What changed
.tsvand.tabas CSV inputs across pandas, Polars, and Spark.--csv-delimiteras an override for both inputs.Why
The CLI already inferred each file's format independently, but the delimiter was one shared value that defaulted to a comma. A TSV file could therefore reach the correct reader and still be parsed into one malformed column. Keeping the parser default unset lets the loaders distinguish an explicit override from normal extension-based inference.
Validation
pytest tests/cli/test_compare.py tests/cli/test_parser.py tests/cli/test_spark.py -q— 124 passed, 5 skippedruff check datacompy/cli tests/cliruff format --check datacompy/cli tests/climypy --follow-imports=skip --ignore-missing-imports datacompy/cli/backends.pysphinx-build -b html docs/source docs/build/html(builds with the existingapi/modulestoctree warning)