fix: use flex-start instead of start for align-items#516
Open
matthewdean wants to merge 1 commit intocaplin:masterfrom
Open
fix: use flex-start instead of start for align-items#516matthewdean wants to merge 1 commit intocaplin:masterfrom
matthewdean wants to merge 1 commit intocaplin:masterfrom
Conversation
The `start` keyword for `align-items` has mixed browser support in flexbox contexts. This causes autoprefixer to emit a warning: (84:3) autoprefixer: start value has mixed support, consider using flex-start instead `flex-start` is the canonical flexbox value with universal support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
align-items: startdeclaration in_base.scsshas mixed browser support in flexbox contexts, causing autoprefixer to emit a warning during builds:This changes
align-items: starttoalign-items: flex-startin the source SCSS and recompiles the theme CSS files.flex-startis the canonical flexbox value with universal browser support.