Made the sync display actually useful #1332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information the media controls gives me is limited, so this implementation is the best I got
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
captbaritone
reviewed
Dec 2, 2025
| mediaStatus === MEDIA_STATUS.PLAYING && | ||
| !(kbps != null && | ||
| khz != null && | ||
| kbps.trim() !== "0"); |
Owner
There was a problem hiding this comment.
Maybe this whole expression could become a new selector getIsWorking? That way we would get memoization.
This kbps.trim() !== "0" string comparison seems sus especially given that we do a padded string if kbps is falsy. Are you sure it's "0" and not "00"? Either way, would be much cleaner if we could check this before we transform it into a string.
Very awkward to do "convert nullish/missing into a specific default string" followed by "check for this specific default string to detect if it's nullish/missing.
Better to go up to the source.
Owner
|
GitHub CI is pointing out legit lint errors here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information the media controls gives me is limited, so this implementation is the best I got