Skip to content

Conversation

@sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Oct 29, 2025

Closes #618

Toolbar component developed as part of Workspace is moved out of it and made to a general component.

Changelog

New

  • Created a toolbar component under @carbon/ai-chat-components
  • As per @devadula-nandan’s suggestion, I’ve also added the flush prop.

Testing / Reviewing

This can be tested in the components storybook.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for carbon-ai-chat-components ready!

Name Link
🔨 Latest commit 4d570fe
🔍 Latest deploy log https://app.netlify.com/projects/carbon-ai-chat-components/deploys/6918375c8cd91f0008791c2c
😎 Deploy Preview https://deploy-preview-617--carbon-ai-chat-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for carbon-ai-chat-demo ready!

Name Link
🔨 Latest commit 4d570fe
🔍 Latest deploy log https://app.netlify.com/projects/carbon-ai-chat-demo/deploys/6918375cba1a580008bc9d81
😎 Deploy Preview https://deploy-preview-617--carbon-ai-chat-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review October 31, 2025 15:53
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner October 31, 2025 15:53
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for ai-chat-components-react ready!

Name Link
🔨 Latest commit 4d570fe
🔍 Latest deploy log https://app.netlify.com/projects/ai-chat-components-react/deploys/6918375cddf60d0009e9535d
😎 Deploy Preview https://deploy-preview-617--ai-chat-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@ethanwinters ethanwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a slot before the title, too, for "navigation" where we can put hamburger menu or icon for home screen.

I also would consider just making it flush by default and removing that attribute and letting folks just define padding on their own if they wish. I would also remove the border and let folks add that on their own (we, for instance, don't want a border when using this in the chat header).

@sangeethababu9223
Copy link
Member Author

We need a slot before the title, too, for "navigation" where we can put hamburger menu or icon for home screen.

I also would consider just making it flush by default and removing that attribute and letting folks just define padding on their own if they wish. I would also remove the border and let folks add that on their own (we, for instance, don't want a border when using this in the chat header).

Hey @ethanwinters ,
The above changes are done. Please check.

Copy link
Contributor

@ethanwinters ethanwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to sort out. Looks great!


return html`
<div
data-rounded="top"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this data-rounded="top"? Doesn't seem to do anything? If its supposed to be rounding the corners, it isn't. And if it is supposed to be rounding the corners, it should be configurable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its supposed to work in the context of the css custom property.
it makes sense when we start integrating this in ai-chat that defines that custom property.
also i am bringing few changes to make that property more generic and relevant to utility. in this pr. so my eyes are on it to make the updates.

Screen.Recording.2025-11-20.at.7.11.36.AM.mov

@devadula-nandan devadula-nandan added this pull request to the merge queue Nov 19, 2025
Merged via the queue into carbon-design-system:main with commit 61bda48 Nov 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Toolbar component in ai-chat-components

3 participants