-
Notifications
You must be signed in to change notification settings - Fork 8
feat(toolbar): component in ai chat components #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toolbar): component in ai chat components #617
Conversation
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a slot before the title, too, for "navigation" where we can put hamburger menu or icon for home screen.
I also would consider just making it flush by default and removing that attribute and letting folks just define padding on their own if they wish. I would also remove the border and let folks add that on their own (we, for instance, don't want a border when using this in the chat header).
…babu9223/carbon-ai-chat-open into feat/toolbar-component
Hey @ethanwinters , |
ethanwinters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment to sort out. Looks great!
|
|
||
| return html` | ||
| <div | ||
| data-rounded="top" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this data-rounded="top"? Doesn't seem to do anything? If its supposed to be rounding the corners, it isn't. And if it is supposed to be rounding the corners, it should be configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its supposed to work in the context of the css custom property.
it makes sense when we start integrating this in ai-chat that defines that custom property.
also i am bringing few changes to make that property more generic and relevant to utility. in this pr. so my eyes are on it to make the updates.
Screen.Recording.2025-11-20.at.7.11.36.AM.mov
61bda48
Closes #618
Toolbar component developed as part of Workspace is moved out of it and made to a general component.
Changelog
New
@carbon/ai-chat-componentsTesting / Reviewing
This can be tested in the components storybook.