fix(DatePicker): prevent invalid/warn states when disabled/readonly #20828

Tiss29 · 2025-10-28T12:24:22Z

Fixed DatePicker components in both React and Web Components to not show invalid/warn states when in disabled or readonly state, as users cannot interact with these components in those states.

Closes #20722

Fix DatePicker components to not show invalid/warn states when disabled or readonly

Changelog

New

Added tests in DatePicker-test.js and date-picker_spec.ts to verify invalid/warn states are not shown when disabled or readonly.

Changed

Added disabled prop to DatePicker.tsx and modified child component props to include conditions for invalid/warn states.
Updated DatePickerInput.tsx to not apply invalid/warn CSS classes when disabled/readonly.
Modified useNormalizedInputProps.tsx to check for disabled state when setting invalid/warn properties.
Updated date-picker-input.ts to check for disabled state in normalizedProps.
Added CSS rules in _date-picker.scss to remove invalid/warn styling for disabled and readonly inputs.
Added CSS rules in date-picker.scss for web components implementation.

Testing / Reviewing

Access DatePicker on storybook and change the state to "Invalid = true" and "disabled = true". The invalid message should not be shown.
Repeat above test with "readOnly = true" instead of disabled. The invalid message should not be shown.
Repeat the two tests above using "warn = true" instead of "invalid = true". The warning message on both scenarios should not be shown.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

Reviewed every line of the diff
Updated documentation and storybook examples
Wrote passing tests that cover this change
Addressed any impact on accessibility (a11y)
Tested for cross-browser consistency
Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

Fixed DatePicker components in both React and Web Components to not show invalid/warn states when in disabled or readonly state, as users cannot interact with these components in those states.

github-actions · 2025-10-28T12:24:41Z

All contributors have signed the DCO.
_{Posted by the DCO Assistant Lite bot.}

netlify · 2025-10-28T12:30:54Z

✅ Deploy Preview for v11-carbon-web-components ready!

Name	Link
🔨 Latest commit	`7394ff7`
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-web-components/deploys/692961b2af85060008ec8f93
😎 Deploy Preview	https://deploy-preview-20828--v11-carbon-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-10-28T12:32:21Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`7394ff7`
🔍 Latest deploy log	https://app.netlify.com/projects/carbon-elements/deploys/692961b22c867d000851860e
😎 Deploy Preview	https://deploy-preview-20828--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-10-28T12:33:21Z

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7394ff7`
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-react/deploys/692961b27ee39000075586eb
😎 Deploy Preview	https://deploy-preview-20828--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Tiss29 · 2025-10-28T12:53:03Z

I have read the DCO document and I hereby sign the DCO.

Tiss29 · 2025-10-28T12:53:09Z

recheck

Tiss29 · 2025-10-28T13:07:17Z

I have read the DCO document and I hereby sign the DCO.

maradwan26

Thanks for contributing! Just some comments on coding conventions and best practices

packages/react/src/components/DatePicker/DatePicker.tsx

packages/react/src/components/DatePickerInput/DatePickerInput.tsx

packages/styles/scss/components/date-picker/_date-picker.scss

packages/react/src/components/DatePickerInput/DatePickerInput.tsx

maradwan26 · 2025-10-28T18:23:17Z

@Tiss29 You'll need to sign the DCO with both accounts used to pass the DCO check

codecov · 2025-10-28T18:28:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (50b0404) to head (7394ff7).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20828      +/-   ##
==========================================
- Coverage   92.62%   92.32%   -0.30%     
==========================================
  Files         515      529      +14     
  Lines       38222    40630    +2408     
  Branches     5805     5841      +36     
==========================================
+ Hits        35403    37513    +2110     
- Misses       2670     2968     +298     
  Partials      149      149

Flag	Coverage Δ
main-packages	`85.60% <100.00%> (-0.01%)`	⬇️
web-components	`96.06% <100.00%> (-0.82%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fixed DatePicker components in both React and Web Components to not show invalid/warn states when in disabled or readonly state, as users cannot interact with these components in those states.

Tiss29 · 2025-10-29T14:15:08Z

@maradwan26 I have a doubt regarding the requirement to “sign the DOC with both accounts.”
Could you please clarify which accounts specifically need to sign it?

maradwan26 · 2025-10-29T15:28:59Z

@Tiss29 The DCO checker says you need to sign it with @Tiss-Joseph because there are commits authored by that account

Tiss-Joseph · 2025-10-30T11:50:02Z

I have read the DCO document and I hereby sign the DCO.

maradwan26

The invalid outline still shows with the disabled and readonly states in Web Components

There are also still some added styles in this PR that should be removed as this implementation should only be done in the component file.
Tests are failing for React

packages/react/src/components/DatePicker/DatePicker.tsx

packages/web-components/tests/spec/date-picker_spec.ts

- Fix invalid outline showing with disabled/readonly states in Web Components - Remove duplicate styles from shared _date-picker.scss - Fix failing React tests by moving props to DatePickerInput - Remove unused disabled prop from DatePicker.tsx - Move Web Components tests to correct __tests__ directory - Remove accidental comment from test file

Tiss29 · 2025-11-06T05:09:58Z

@maradwan26 Could please check

maradwan26

Invalid outline shows when disabled/readonly is set to "true" in Web Components

packages/web-components/src/components/date-picker/__tests__/date-picker-test.js

Tiss29 · 2025-11-06T18:07:19Z

@maradwan26 in my web component action I couldn't see invalid

do I need to enable something while running storybook

maradwan26 · 2025-11-06T18:21:03Z

@Tiss29

The control for invalid is missing in the story, but you can manually set it via inspect element, then set disabled to true with the control panel

You can also add the controls in

date-picker/date-picker.stories.ts

- Fix test file to use @open-wc/testing fixture pattern - Fix invalid outline showing when disabled or readonly is true - Add invalid/invalidText controls to Storybook stories

Tiss29 · 2025-11-06T19:20:12Z

@maradwan26 Please recheck

maradwan26 · 2025-11-06T20:56:43Z

@Tiss29

Tests are failing for web components.

You can run the tests locally by running yarn web-test-runner "src/components/date-picker/__tests__/date-picker-test.js" in packages/web-components

Tiss29 · 2025-11-24T08:53:24Z

@maradwan26 I fix the test

maradwan26

LGTM just a couple final suggestions/tweaks!

packages/web-components/src/components/date-picker/date-picker.scss

maradwan26 · 2025-11-27T21:06:24Z

packages/web-components/src/components/date-picker/date-picker.scss

+:host(#{$prefix}-date-picker-input[disabled]),
+:host(#{$prefix}-date-picker-input[readonly]) {
+  .#{$prefix}--form-requirement {
+    display: none;
+  }
+
+  .#{$prefix}--date-picker__input--invalid,
+  .#{$prefix}--date-picker__input--warn {
+    border-block-end: 1px solid transparent;
+  }
+}
+


Suggested change

:host(#{$prefix}-date-picker-input[disabled]),

:host(#{$prefix}-date-picker-input[readonly]) {

.#{$prefix}--form-requirement {

display: none;

}

.#{$prefix}--date-picker__input--invalid,

.#{$prefix}--date-picker__input--warn {

border-block-end: 1px solid transparent;

}

}

Same here, this is already accounted for in the component .ts file

okay I will remove them

maradwan26 · 2025-11-27T21:06:56Z

packages/web-components/tests/spec/date-picker_spec.ts

    beforeEach(async () => {
      render(defaultTemplate(), document.body);
      await Promise.resolve();
      datePicker = document.body.querySelector('cds-date-picker');


I think you should be good to leave this file unchanged.

okay will revert

packages/web-components/src/components/date-picker/__tests__/date-picker-test.js

….scss Co-authored-by: Mahmoud <[email protected]>

…ate-picker-test.js Co-authored-by: Mahmoud <[email protected]>

Tiss29 · 2025-11-28T08:48:13Z

@maradwan26 @alisonjoseph Please check

fix(DatePicker): prevent invalid/warn states when disabled/readonly

376c170

Fixed DatePicker components in both React and Web Components to not show invalid/warn states when in disabled or readonly state, as users cannot interact with these components in those states.

Tiss29 marked this pull request as ready for review October 28, 2025 12:53

Tiss29 requested a review from a team as a code owner October 28, 2025 12:53

Tiss29 requested review from alisonjoseph and maradwan26 October 28, 2025 12:53

Merge branch 'main' into DatePicker

590bb44

maradwan26 requested changes Oct 28, 2025

View reviewed changes

maradwan26 added the hacktoberfest See https://hacktoberfest.com/ label Oct 28, 2025

fix(DatePicker): prevent invalid/warn states when disabled/readonly

a52071f

Fixed DatePicker components in both React and Web Components to not show invalid/warn states when in disabled or readonly state, as users cannot interact with these components in those states.

Tiss29 added 2 commits October 30, 2025 17:39

Merge branch 'main' into DatePicker

8b465cc

Merge branch 'main' into DatePicker

369080b

Tiss29 deployed to @carbon/react storybook preview October 30, 2025 17:03 — with GitHub Actions View deployment

maradwan26 requested changes Oct 30, 2025

View reviewed changes

packages/react/src/components/DatePicker/DatePicker.tsx Outdated Show resolved Hide resolved

packages/web-components/tests/spec/date-picker_spec.ts Outdated Show resolved Hide resolved

Tiss-Joseph and others added 3 commits November 5, 2025 20:29

Merge branch 'main' into DatePicker

722a4c6

Merge branch 'main' into DatePicker

43b2b87

maradwan26 requested changes Nov 6, 2025

View reviewed changes

Tiss29 and others added 2 commits November 7, 2025 00:47

Merge branch 'main' into DatePicker

8296653

fix(date-picker): prevent invalid state when disabled/readonly

9a96835

- Fix test file to use @open-wc/testing fixture pattern - Fix invalid outline showing when disabled or readonly is true - Add invalid/invalidText controls to Storybook stories

Tiss29 deployed to @carbon/react storybook preview November 6, 2025 21:08 — with GitHub Actions View deployment

alisonjoseph added the status: failing CI 🙅‍♂️ label Nov 10, 2025

Tiss29 and others added 2 commits November 24, 2025 13:36

Merge branch 'main' into DatePicker

7bb6df8

fix(date-picker): prevent invalid state when disabled/readonly

5760fce

maradwan26 approved these changes Nov 27, 2025

View reviewed changes

maradwan26 reviewed Nov 27, 2025

View reviewed changes

packages/web-components/src/components/date-picker/__tests__/date-picker-test.js Outdated Show resolved Hide resolved

maradwan26 removed the status: failing CI 🙅‍♂️ label Nov 27, 2025

Merge branch 'main' into DatePicker

1e4f4b1

maradwan26 deployed to @carbon/react storybook preview November 27, 2025 21:42 — with GitHub Actions View deployment

Tiss29 and others added 4 commits November 28, 2025 13:50

Update packages/web-components/src/components/date-picker/date-picker…

06b4074

….scss Co-authored-by: Mahmoud <[email protected]>

Update packages/web-components/src/components/date-picker/__tests__/d…

9432cbd

…ate-picker-test.js Co-authored-by: Mahmoud <[email protected]>

fix(date-picker): prevent invalid state when disabled/readonly

f89fb62

fix(date-picker): prevent invalid state when disabled/readonly

7394ff7

Tiss29 deployed to @carbon/react storybook preview December 1, 2025 16:44 — with GitHub Actions View deployment

fix(DatePicker): prevent invalid/warn states when disabled/readonly #20828

Are you sure you want to change the base?

fix(DatePicker): prevent invalid/warn states when disabled/readonly #20828

Uh oh!

Conversation

Tiss29 commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Testing / Reviewing

PR Checklist

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v11-carbon-web-components ready!

Uh oh!

netlify bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for carbon-elements ready!

Uh oh!

netlify bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v11-carbon-react ready!

Uh oh!

Tiss29 commented Oct 28, 2025

Uh oh!

Tiss29 commented Oct 28, 2025

Uh oh!

Tiss29 commented Oct 28, 2025

Uh oh!

maradwan26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maradwan26 commented Oct 28, 2025

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Tiss29 commented Oct 29, 2025

Uh oh!

maradwan26 commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tiss-Joseph commented Oct 30, 2025

Uh oh!

maradwan26 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Tiss29 commented Nov 6, 2025

Uh oh!

maradwan26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tiss29 commented Nov 6, 2025

Uh oh!

maradwan26 commented Nov 6, 2025

Uh oh!

Tiss29 commented Nov 6, 2025

Uh oh!

maradwan26 commented Nov 6, 2025

Uh oh!

Tiss29 commented Nov 24, 2025

Uh oh!

maradwan26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Tiss29 commented Oct 28, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading

netlify bot commented Oct 28, 2025 •

edited

Loading

netlify bot commented Oct 28, 2025 •

edited

Loading

netlify bot commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading

maradwan26 commented Oct 29, 2025 •

edited

Loading

maradwan26 left a comment •

edited

Loading

Tiss29 commented Nov 28, 2025 •

edited

Loading