Skip to content

fix: correct Dropdown keyboard typing detection logic #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −9
Open

fix: correct Dropdown keyboard typing detection logic #20860

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2caa3f5
packages/react/src/components/Dropdown/Dropdown.tsx
naaa760 Nov 3, 2025
2bff6d9
Merge branch 'main' into audit/dropdown
riddhybansal Nov 18, 2025
a31e736
Merge branch 'main' into audit/dropdown
maradwan26 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions packages/react/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,16 +531,22 @@ const Dropdown = React.forwardRef(

const onKeyDownHandler = useCallback(
(evt: React.KeyboardEvent<HTMLButtonElement>) => {
if (
evt.code !== 'Space' ||
!['ArrowDown', 'ArrowUp', ' ', 'Enter'].includes(evt.key)
) {
const navigationKeys = ['ArrowDown', 'ArrowUp', ' ', 'Enter'];

// If the key is not a navigation key, the user is typing
if (!navigationKeys.includes(evt.key)) {
setIsTyping(true);
}
if (
(isTyping && evt.code === 'Space') ||
!['ArrowDown', 'ArrowUp', ' ', 'Enter'].includes(evt.key)
) {
// Reset the timer for typing timeout
if (currTimer) {
clearTimeout(currTimer);
}
setCurrTimer(
setTimeout(() => {
setIsTyping(false);
}, 3000)
);
} else if (isTyping && evt.key === ' ') {
// If user is typing and presses space, reset the timer
if (currTimer) {
clearTimeout(currTimer);
}
Expand All @@ -550,6 +556,7 @@ const Dropdown = React.forwardRef(
}, 3000)
);
}

if (['ArrowDown'].includes(evt.key)) {
setIsFocused(false);
}
Expand Down
Loading