-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(combo-box): align invalid style and ai-label position #20978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(combo-box): align invalid style and ai-label position #20978
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20978 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 511 511
Lines 37341 37341
Branches 5677 5738 +61
=======================================
Hits 34478 34478
+ Misses 2715 2714 -1
- Partials 148 149 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #20120
Closes #20849
Fixes issues with
Comboboxinvalid and warnicon positioning andAI labelmissing gradient and spacing.Changelog
New
Comboboxstorybook.Changed
Removed
Testing / Reviewing
WC Deploy Preview>Combobox>Default&With Ai Label.Comboboxlooks similar to the expected image (this is from MultiSelect, designs needs confirm if is ok):Invalid/warnstates inDefaultandWith Ai Labelstories should fit the design spec.e.g:

e.g:

PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide