feat(release): publish watchdog image to GHCR and Docker Hub#17
Open
stephenctw wants to merge 2 commits into
Open
feat(release): publish watchdog image to GHCR and Docker Hub#17stephenctw wants to merge 2 commits into
stephenctw wants to merge 2 commits into
Conversation
Push ghcr.io/cartesi/sequencer-watchdog:<tag> (multi-arch manifest) alongside existing docker-save tarballs. Mirrors cartesi/cli container publishing so operators can COPY --from= in custom rootfs builds (e.g. Fly.io). Requires DOCKERHUB_USERNAME and DOCKERHUB_TOKEN repo secrets for Docker Hub mirror.
endersonmaia
requested changes
Jun 23, 2026
endersonmaia
left a comment
endersonmaia
left a comment
Contributor
There was a problem hiding this comment.
I strongly suggest using the docker/build-push-action instead of handling stuff via docker commands.
Address PR review: push ghcr.io and docker.io tags without arch suffixes (buildx assembles the multi-arch manifest), replace shell docker build/push with docker/build-push-action, and drop the separate imagetools manifest job.
stephenctw
force-pushed
the
feature/release-publish-watchdog-ghcr
branch
from
19faf39 to
9abc31a
Compare
Collaborator
Author
Can you take a look if the new change makes sense? |
endersonmaia
requested changes
Jun 23, 2026
Comment on lines
+233
to
+255
| - name: Export docker-save tarball for GitHub Release | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| file: watchdog/Dockerfile | ||
| platforms: ${{ matrix.platform }} | ||
| push: false | ||
| tags: sequencer-watchdog:export | ||
| outputs: type=docker,dest=${{ runner.temp }}/watchdog-image.tar | ||
| build-args: | | ||
| RELEASE_TAG=${{ inputs.tag || github.ref_name }} | ||
| GIT_COMMIT=${{ github.sha }} | ||
| CARTESI_MACHINE_VERSION=${{ env.CARTESI_MACHINE_VERSION }} | ||
| CARTESI_MACHINE_DEB_SHA256=${{ steps.cartesi_deb.outputs.sha }} | ||
| cache-from: type=gha | ||
|
|
||
| - name: Compress docker-save artifact | ||
| env: | ||
| TAG: ${{ inputs.tag || github.ref_name }} | ||
| run: | | ||
| set -euo pipefail | ||
| DEB_SHA="${!DEB_SHA_ENV}" | ||
| image="sequencer-watchdog:${TAG}" | ||
| docker build \ | ||
| --platform "${{ matrix.platform }}" \ | ||
| --build-arg "RELEASE_TAG=${TAG}" \ | ||
| --build-arg "GIT_COMMIT=${GITHUB_SHA}" \ | ||
| --build-arg "CARTESI_MACHINE_VERSION=${CARTESI_MACHINE_VERSION}" \ | ||
| --build-arg "CARTESI_MACHINE_DEB_SHA256=${DEB_SHA}" \ | ||
| -f watchdog/Dockerfile \ | ||
| -t "${image}" \ | ||
| . | ||
| mkdir -p dist | ||
| docker save "${image}" | gzip -9 > "dist/sequencer-watchdog-${TAG}-linux-${{ matrix.arch }}.tar.gz" | ||
| gzip -9 -c "${{ runner.temp }}/watchdog-image.tar" > "dist/sequencer-watchdog-${TAG}-linux-${{ matrix.arch }}.tar.gz" |
Contributor
There was a problem hiding this comment.
Unless you insist in releasing an OCI tarball, I'd remove all of this.
If we're gonna release via container registry, this tarball release makes no sense to me.
One could always pull from registry and generate the tarball themselves.
| @@ -188,25 +193,66 @@ jobs: | |||
| - name: Set up Docker Buildx | |||
| uses: docker/setup-buildx-action@v4 | |||
|
|
|||
Contributor
There was a problem hiding this comment.
I mss a setup-qemu action so the multiarch can work.
Suggested change
| - name: Set up QEMU | |
| uses: docker/setup-qemu-action@v4 | |
| | Docker Hub | `docker.io/cartesi/sequencer-watchdog:vX` | | ||
|
|
||
| Multi-arch manifest (`amd64` + `arm64`). Per-arch tags also exist as | ||
| `vX-amd64` / `vX-arm64` if you need to pin architecture explicitly. |
Contributor
There was a problem hiding this comment.
I don't think we have those vX-$arch tags.
Suggested change
| `vX-amd64` / `vX-arm64` if you need to pin architecture explicitly. | |
| Multi-arch manifest (`amd64` + `arm64`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push ghcr.io/cartesi/sequencer-watchdog: (multi-arch manifest) alongside existing docker-save tarballs. Mirrors cartesi/cli container publishing so operators can COPY --from= in custom rootfs builds (e.g. Fly.io).
Requires DOCKERHUB_USERNAME and DOCKERHUB_TOKEN repo secrets for Docker Hub mirror.