Skip to content

feat: support partial paymaster fees#2367

Open
tarrencev wants to merge 4 commits into
mainfrom
partialsub
Open

feat: support partial paymaster fees#2367
tarrencev wants to merge 4 commits into
mainfrom
partialsub

Conversation

@tarrencev

@tarrencev tarrencev commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add partial paymaster detection and fee UI labeling.
  • Route partial sponsorship through execute-from-outside with appended STRK fee transfer.
  • Add tests and mocks for partial fee estimates.

Testing

  • pnpm lint:check (failed: turbo not found; node_modules missing)

@vercel

vercel Bot commented Feb 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 3, 2026 10:47pm
keychain Ready Ready Preview Feb 3, 2026 10:47pm
keychain-storybook Ready Ready Preview Feb 3, 2026 10:47pm

Request Review

@claude

claude Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Code review

Found 1 issue:

Missing import for FeeEstimate type

File: packages/keychain/src/utils/connection/execute.ts (lines 7-15)

The code at line 110 uses FeeEstimate:

let feeEstimate: FeeEstimate | undefined;

However, FeeEstimate is not imported from starknet. The import block should include it:

import {
  Abi,
  AllowArray,
  Call,
  CallData,
  FeeEstimate,  // <-- Add this
  InvocationsDetails,
  InvokeFunctionResponse,
  addAddressPadding,
} from "starknet";

See:

import {
Abi,
AllowArray,
Call,
CallData,
InvocationsDetails,
InvokeFunctionResponse,
addAddressPadding,
} from "starknet";


Checked for bugs and CLAUDE.md compliance.

@claude

claude Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant