Do not crash test_all if parametrized is missing#1432
Open
CLOVIS-AI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1422 introduced a thin wrapper around
test_all.pyused to provide compatibility withunittestand related test frameworks. This approach required theparametrizedpackage, which was added to the optional dependencies. However thetest_all.pyscript always imported this package, which led to crashes when it was not installed.This PR edits
test_all.pyso it warns the user of the missingparametrizedpackage and disables theunittestwrapper instead of crashing the script.A much better implementation of the test framework support is underway in serpilliere#8, but it likely will not reach
masterfor some time yet, so this PR applies a bandaid onmasteruntil then.