Repository navigation
Start the cell boundary opacity slider at 50% - #169
Merged
Merged
Conversation
Cell boundaries drew at full opacity by default, while cell fill already started at 50%. The boundary default is now 50% too, kept beside the fill default in layerOpacity.ts and used by the shareable defaults, ViewerCore and the deck layer fallback. A link that leaves the setting out now opens at 50%; a dataset manifest's cellBoundaryOpacity still overrides it.
Four tests checked outline colours or update triggers at full opacity without passing cellBoundaryOpacity, so the new 50% default halved the alpha they expected. They test layer building, outlines with fills off and deferred restyling, not the default, so they now pass 1 explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_CELL_BOUNDARY_OPACITYsits besideDEFAULT_CELL_FILL_OPACITYinsrc/rendering/layerOpacity.ts.DEFAULT_SHAREABLE_STATE(the slider's starting value),ViewerCore's prop default andcreateOverviewLayers' fallback.docs/ui-reference.mdand the App test that checks the default slider value now say 50%.Share links that left the setting out (because it was at 100%) now open at 50%. A dataset manifest's
cellBoundaryOpacitystill overrides the default.Test plan