Skip to content

Start the cell boundary opacity slider at 50% - #169

Merged
prete merged 2 commits into
mainfrom
claude/cell-boundary-opacity-default
Nov 18, 2026
Merged

prete merged 2 commits into
mainfrom
claude/cell-boundary-opacity-default

Conversation

@prete

@prete prete commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Cell boundaries now default to 50% opacity, matching cell fill. The new DEFAULT_CELL_BOUNDARY_OPACITY sits beside DEFAULT_CELL_FILL_OPACITY in src/rendering/layerOpacity.ts.
  • It is used by DEFAULT_SHAREABLE_STATE (the slider's starting value), ViewerCore's prop default and createOverviewLayers' fallback.
  • docs/ui-reference.md and the App test that checks the default slider value now say 50%.

Share links that left the setting out (because it was at 100%) now open at 50%. A dataset manifest's cellBoundaryOpacity still overrides the default.

Test plan

  • CI: typecheck, lint and unit tests (not run locally)

Cell boundaries drew at full opacity by default, while cell fill already
started at 50%. The boundary default is now 50% too, kept beside the fill
default in layerOpacity.ts and used by the shareable defaults, ViewerCore
and the deck layer fallback. A link that leaves the setting out now opens
at 50%; a dataset manifest's cellBoundaryOpacity still overrides it.
Four tests checked outline colours or update triggers at full opacity
without passing cellBoundaryOpacity, so the new 50% default halved the
alpha they expected. They test layer building, outlines with fills off
and deferred restyling, not the default, so they now pass 1 explicitly.
@prete
prete merged commit 605663a into main Nov 18, 2026
6 of 7 checks passed
@prete
prete deleted the claude/cell-boundary-opacity-default branch November 18, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant